Conversation
There was a problem hiding this comment.
Pull request overview
This PR restores the Delegator.delegating_block method, replacing the previous delegating_code approach for defining special (non-standard) method names in delegated classes. The change simplifies the implementation by using a lambda with define_method instead of string-based code generation with module_eval.
- Replaces
delegating_code(which generated evaluable source code strings) withdelegating_block(which returns a lambda) - Simplifies method definition for special methods (operators like
[],==, etc.) by usingdefine_methodwith a lambda instead ofmodule_evalwith generated source code - Maintains proper keyword argument handling through
.ruby2_keywordsannotation on the lambda
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#53 (comment)